-
Notifications
You must be signed in to change notification settings - Fork 33
feat: implement get_view_names() method #306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@asthamohta, this also adds small changes to make the test suites ignore SQLAlchemy 2.0 as it includes a lot of breaking changes. One strange thing I noticed is that the SQL query SELECT table_name
FROM information_schema.viewsReturns lists of strings. Is the |
|
Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot. |
|
I don't know what kokoro is like at all. However, according to the error message, it was failed due to timeout apparently. |
|
@asthamohta Is there anything I can help? I would like to go ahead with the issue. |
Closes #303