fix: Fixing test for literals due to change in sqlalchemy core tests #384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: spanner
ankiaga
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
ankiaga
added
kokoro:force-run
snippet-bot
bot
removed
the
snippet-bot:force-run
yoshi-kokoro
removed
the
kokoro:force-run
olavloite
approved these changes
Jan 31, 2024
parthea
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are couple of changes in this PR to fix this repo pipeline which is failing from last 3 months:
Spanner doesn't supports inserting 2 rows (a row with NULL value and a row with some value for a given datatype) for a table with empty primary key. SqlAlchemy added tests couple of months back to insert 2 such rows for different datatypes columns so those tests started failing for this repo.
Fixing to override those tests so as not to insert a row with NULL value but just a single row for each datatype
tests: remove editable install in tests
accommodate NULL at the compiler level for literal_render. Please see sqlalchemy/sqlalchemy@1a23c8d where are copying changes from compiler.py