Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Refactoring] Create a copy of samples/samples/testdata in tests/testdata #1180

Open
bhatt4982 opened this issue Aug 6, 2024 · 0 comments
Open

[Refactoring] Create a copy of samples/samples/testdata in tests/testdata #1180

bhatt4982 opened this issue Aug 6, 2024 · 0 comments
Assignees
@naren-mehra
Labels
api: spanner Issues related to the googleapis/python-spanner API. samples Issues that are directly related to samples.

Comments

@bhatt4982
Copy link
Contributor

[Refactoring] Create a copy of samples/samples/testdata in tests

  • tests depends on testdata in samples/samples/testdata
    • test__helpers.py
    • test__param_types.py
  • Removing this dependency

Is your feature request related to a problem? Please describe.
Dependencies creates error as samples folder is not synced
Describe the solution you'd like
Create a copy of testdata inside tests/
Describe alternatives you've considered
NA
Additional context
NA
@product-auto-label product-auto-label bot added api: spanner Issues related to the googleapis/python-spanner API. samples Issues that are directly related to samples. labels Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@naren-mehra naren-mehra

Labels
api: spanner Issues related to the googleapis/python-spanner API. samples Issues that are directly related to samples.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bhatt4982 @naren-mehra