Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support predefined_acl in create_resumable_upload_session #877

Closed
Tracked by #320
ddelange opened this issue Sep 28, 2022 · 2 comments · Fixed by #878
Closed
Tracked by #320

Support predefined_acl in create_resumable_upload_session #877

ddelange opened this issue Sep 28, 2022 · 2 comments · Fixed by #878
Assignees
@cojenco
Labels
api: storage Issues related to the googleapis/python-storage API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@ddelange
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Hi 👋 I'm a user of smart_open, and would like to propagate a predefined_acl. They use create_resumable_upload_session which seemingly is the only function related to blob uploads that does not accept the predefined_acl kwarg.

Describe the solution you'd like

Allow passing predefined_acl kwarg to create_resumable_upload_session.

Describe alternatives you've considered

Additional context
stevearc/pypicloud#317 (comment)
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/python-storage API. label Sep 28, 2022
This was referenced Sep 28, 2022
Merged
Closed
Merged
@ddelange
Copy link
Contributor Author

Opened #878

@ddelgrosso1 ddelgrosso1 added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p3 Desirable enhancement or fix. May not be included in next release. labels Sep 28, 2022
@cojenco
Copy link
Contributor

cojenco commented Sep 29, 2022

Hi @ddelange thanks for contributing! Our team will work with you on reviewing the PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cojenco cojenco

Labels
api: storage Issues related to the googleapis/python-storage API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add predefined_acl to create_resumable_upload_session ddelange/python-storage
3 participants
@ddelange @cojenco @ddelgrosso1