plugin node_workspace doesn't work with pnpm?

[agufagit]

I'm trying to update local deps, monorepo is pnpm workspace

i tried to use plugin node_workspace, and got error:

Unsupported URL Type "workspace:": workspace:^0.2.0

I see that there is no way to write a custom manifest plugin

I did write a script, which's just simply 'cd' into each package folder, regex match workspace deps in package.json, and run 'pnpm update --workspace @scope/package1 @scope/package2'. The reason to run 'pnpm update' is to update pnpm-lock.yaml file also, for pnpm --frozen-lock option.

I'm not sure if this script fits your plugin system, if you want this, I can contribute

[chingor13]

I don't recognize that error message Unsupported URL Type "workspace:": workspace:^0.2.0, do you have a stack trace for it (and an example of your config)?

Manifest plugins are abstracted in this repository and you should be able to register new plugin types if you control the execution environment of release-please (i.e. we run a GitHub bot on GCP that uses the release-please library where we could theoretically register additional plugins). The CLI does not have a built-in dynamic loader for plugins (yet).

As for the design of this library, we do not shell out to manipulate code as a design decision because we didn't want to add additional requirements on the runtime (like requiring additional binaries). If you'd like to contribute a pnpm-workspace plugin to this repository, it would probably be useful to others as well.

[chingor13]

Related: #1098

[agufagit]

I'll do it in my spare time, so this means I have to manually modify pnpm-lock.yaml file right?

[chingor13]

modify pnpm-lock.yaml file right?

I'm not sure exactly how a pnpm workspace works, but we do have updaters already for generic yaml files and workspace plugins can add additional files to update.

[oneton]

I've run into the same problem. My Github action failed after logging "Building list of all packages". I must admit I did not run a debugger, but by analysing the code I found the following:

• NodeWorkspace->buildAllPackages (node-workspace.ts) is called from the WorkspacePlugin
• This method creates instances of Package (defined in the same file), which extends Package from @lerna/package
• The constructor for @lerna/package calls resolve() from downstream dependency npm-package-arg
• npm-package-arg doesn't recognise the workspace: protocol

It seems lerna is working on pnpm support as we speak, which will most likely resolve the issue.
lerna/lerna#3284

[agufagit]

awesome, I'll just wait then

[oneton]

It might be useful to keep this issue open. Updating the lerna dependencies would be the minimum change required to address this once the lerna changes have been completed.

[agufagit]

ok

[freddy38510]

Hello guys,

I just noticed that the commit has been merged and lerna v5.5.0 supports pnpm.

[re-taro]

Hello, I have the same issue.

I would assume that this PR will be resolved once it is merged, but what do you think?

[lotyp]

Hey, I'm currently using changesets in my pnpm monorepo, but I would like to switch to release-please.
As I understand, release-please currently can't generate Changelog if a repository uses pnpm and workspace:* tags in package.log?

[mpetrunic]

@chingor13 Merging #1449 will add support for this^^

[nahsi]

Still doesn't work with pnpm.
#1819 added yarn support.