Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add generic TOML updater #1833

Merged
merged 2 commits into from
Jan 26, 2023
Merged

feat: Add generic TOML updater #1833

merged 2 commits into from
Jan 26, 2023

Conversation

phated
Copy link
Contributor

@phated phated commented Jan 26, 2023

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #1832 🦕

@phated phated requested a review from a team as a code owner January 26, 2023 21:13
@phated phated requested a review from a team January 26, 2023 21:13
@product-auto-label product-auto-label bot added the size: l Pull request size is large. label Jan 26, 2023
@phated
Copy link
Contributor Author

phated commented Jan 26, 2023

Also, I just want to say that the toml-edit.ts code is totally awesome and I really wish it were a separate dependency that other projects could consume. ❤️

@phated phated force-pushed the phated/generic-toml-updater branch from ea46bb6 to b066a66 Compare January 26, 2023 21:29
@phated phated force-pushed the phated/generic-toml-updater branch from b066a66 to f43d68c Compare January 26, 2023 21:46
chingor13
chingor13 approved these changes Jan 26, 2023
View reviewed changes
Copy link
Contributor

@chingor13 chingor13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@chingor13 chingor13 merged commit 2768a4c into googleapis:main Jan 26, 2023
@release-please release-please bot mentioned this pull request Jan 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chingor13 chingor13 chingor13 approved these changes

Assignees

@chingor13 chingor13

Labels
size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generic TOML updater
2 participants
@phated @chingor13