TOML v1.0.0 spec is not supported. #1836
Labels
priority: p2
Moderately-important priority. Fix may not be included in next release.
type: bug
Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Is this a client library issue or a product issue?
Library
Did someone already solve this?
No
Do you have a support contract?
Please create an issue in the support console to ensure a timely response.
If the support paths suggested above still do not result in a resolution, please provide the following details.
Environment details
release-please
version: fa92311Steps to reproduce
1.1.) Example
pyproject.toml
with a poetry valid "include" field:Attempt to utilize any TOML based updater (via the python strategy, in this case)
release-please silently fails to update the file. Running
manifest
via the github action reports:Details
Release please does not support the latest TOML v1.0.0 spec (which was released Jan 2021).
This means that any TOML files utilizing features introduced in the TOML v1.0.0-rc.1 release silently fail to update.
This is caused by release-please's dependency on @iarna/toml @ v2.2.5, which only advocates support for up to TOML v0.5.0 (2018-07-26).
Please see my earlier issues and PR in renovatebot/renovate (which suffered from the same issue prior) for additional details:
renovatebot/renovate#18668
renovatebot/renovate#18670
The text was updated successfully, but these errors were encountered: