Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TOML v1.0.0 spec is not supported. #1836

Closed
BradenM opened this issue Jan 30, 2023 · 0 comments · Fixed by #1837
Closed

TOML v1.0.0 spec is not supported. #1836

BradenM opened this issue Jan 30, 2023 · 0 comments · Fixed by #1837
Assignees
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@BradenM
Copy link
Contributor

BradenM commented Jan 30, 2023

  1. Is this a client library issue or a product issue?
    Library

  2. Did someone already solve this?
    No

  3. Do you have a support contract?
    Please create an issue in the support console to ensure a timely response.

If the support paths suggested above still do not result in a resolution, please provide the following details.

Environment details

  • OS: N/A
  • Node.js version: N/A
  • npm version: N/A
  • release-please version: fa92311

Steps to reproduce

  1. Create a TOML-based version target file that contains heterogeneous arrays,
    1.1.) Example pyproject.toml with a poetry valid "include" field:
[tool.poetry]
## ...
 include = [ 
   "README.md", 
   { path = "tests", format = "sdist" } 
 ] 
  1. Attempt to utilize any TOML based updater (via the python strategy, in this case)

  2. release-please silently fails to update the file. Running manifest via the github action reports:

❯ Fetching pyproject.toml from branch master
⚠ file pyproject.toml did not exist

Details

Release please does not support the latest TOML v1.0.0 spec (which was released Jan 2021).

This means that any TOML files utilizing features introduced in the TOML v1.0.0-rc.1 release silently fail to update.

This is caused by release-please's dependency on @iarna/toml @ v2.2.5, which only advocates support for up to TOML v0.5.0 (2018-07-26).

Please see my earlier issues and PR in renovatebot/renovate (which suffered from the same issue prior) for additional details:
renovatebot/renovate#18668
renovatebot/renovate#18670

@BradenM BradenM added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants