-
Notifications
You must be signed in to change notification settings - Fork 369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cargo-workspaces): expand globs in crate paths #1852
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is going to work like you think. In release-please, there is no cloned repo so a file glob won't actually look at files on disk. Instead, you will probably want to use our implementation of findFilesByName on the GitHub client instance
That should be fixed now, the github client has a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this, changes look ok, but the tests are failing because it's making a new API call that isn't mocked. We use sinon to mock out methods. Example:
sandbox.stub(github, 'findFilesByGlob').resolves(['path/to/file1.txt', 'path/to/file2.txt']);
Thanks for the review! I couldn’t figure out how to run the tests locally or on my fork, so I just copied a nearby test and hoped for the best! I should be able to work on it tomorrow. |
This should hopefully be fixed, I applied your suggestion. |
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #1851 🦕