fix(sequential-calls): Use push instead of concat when returning releases #1865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erezrokah
changed the title
erezrokah
commented
Feb 27, 2023
| @@ -1116,7 +1116,7 @@ export class Manifest { | |||
| releasesByPullRequest[pullNumber], | |||
| pullRequestsByNumber[pullNumber] | |||
| ); | |||
| resultReleases.concat(releases); | |||
| resultReleases.push(...releases); | |||
There was a problem hiding this comment.
concat does not modify the array, it always returns a new one
|
|
|
Hi lovely release please team 👋 Is there anything missing on my end I should add to this PR? |
chingor13
approved these changes
Mar 7, 2023
|
Thanks for the review, merge and quick release 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #1864 🦕
Fixes https://github.com/google-github-actions/release-please-action/issues/546
Also fixes cloudquery/cloudquery#7787