Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support for "@" sign in component name #1873

Merged
merged 3 commits into from
Mar 14, 2023
Merged

Conversation

raaymax
Copy link
Contributor

@raaymax raaymax commented Mar 13, 2023

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • [ x] Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • [ x] Ensure the tests and linter pass
  • [ x] Code coverage does not decrease (if any source code was changed)
  • [ -] Appropriate docs were updated (if necessary)

Fixes #1872 🦕

@raaymax raaymax requested review from a team as code owners March 13, 2023 12:27
@google-cla
Copy link

google-cla bot commented Mar 13, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Mar 13, 2023
@raaymax raaymax force-pushed the main branch 2 times, most recently from 87fb708 to 7362b5b Compare March 13, 2023 13:01
Copy link
Contributor

@chingor13 chingor13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Mostly LGTM, with a small nit about writing a separate test for this.

test/util/pull-request-title.ts Show resolved Hide resolved
Copy link
Contributor

@chingor13 chingor13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@chingor13 chingor13 merged commit d3b2f2f into googleapis:main Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for "@" sign in component names
2 participants