Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: search depth limitation #1903

Closed
alex-enchi opened this issue Apr 6, 2023 · 3 comments · Fixed by #1915
Closed

Question: search depth limitation #1903

alex-enchi opened this issue Apr 6, 2023 · 3 comments · Fixed by #1915
Assignees
Labels
needs more info This issue needs more information from the customer to proceed. priority: p3 Desirable enhancement or fix. May not be included in next release. type: question Request for information or clarification. Not an issue.

Comments

@alex-enchi
Copy link
Contributor

Hi
I have noticed that no matter how fresh latest release is, release-please always checks last 500 (default) commits.

Is it mandatory behaviour? Or it is possible to fetch commits after latest release?

In my case run of release-please takes around 2 minutes no matter how big release is (even if it just one small fix added to one of the packages)

@alex-enchi alex-enchi added priority: p3 Desirable enhancement or fix. May not be included in next release. type: question Request for information or clarification. Not an issue. labels Apr 6, 2023
@chingor13
Copy link
Contributor

Are you letting release-please tag the releases? How is your repository configured (manifest or programatically via GitHub actions/app inputs)?

Release-please tries needs to find the commit SHA of the latest release. Using a manifest config is usually the most efficient, because the manifest tells release-please what the expected last version is -- it then needs to find the SHA of that release version. Without the manifest, we paginate backwards through commits to try and guess what the last release was.

@chingor13 chingor13 added the needs more info This issue needs more information from the customer to proceed. label Apr 10, 2023
@alex-enchi
Copy link
Contributor Author

I am using manifest, and have a "root" package with multiple packages underneath. Only root gets released via release-please but everything gets tagged and that release commit is captured by release-please according to logs.
But it still goes further away in history by some reasons.
Will check or at least do a reproduction repository to demo the issue.

@alex-enchi
Copy link
Contributor Author

For my release process I have 1 root release with tags @root-v1.2.3, @package-foo-v1.2.3, @package-bar-v1.2.3 and 0 packages github releases. And in the case it finds github release, it finds all the tags but does not go out from the iterator here
because needsBootstrap is true since it consider only github releases and not tags

Here is the small fix #1915

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs more info This issue needs more information from the customer to proceed. priority: p3 Desirable enhancement or fix. May not be included in next release. type: question Request for information or clarification. Not an issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants