Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Property does not exist on type 'Endpoints' #1945

Closed
tekumara opened this issue May 6, 2023 · 3 comments
Closed

Property does not exist on type 'Endpoints' #1945

tekumara opened this issue May 6, 2023 · 3 comments
Assignees
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@tekumara
Copy link

tekumara commented May 6, 2023

Environment details

  • OS: macos
  • Node.js version: 16.16.0
  • npm version: 8.11.0
  • release-please version: v15.10.4 2b56b22

Steps to reproduce

❯ npm run compile

> release-please@15.10.4 compile
> tsc -p .

node_modules/@octokit/plugin-paginate-rest/dist-types/generated/paginating-endpoints.d.ts:21:31 - error TS2339: Property 'GET /enterprises/{enterprise}/actions/runner-groups' does not exist on type 'Endpoints'.

21         parameters: Endpoints["GET /enterprises/{enterprise}/actions/runner-groups"]["parameters"];
                                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

node_modules/@octokit/plugin-paginate-rest/dist-types/generated/paginating-endpoints.d.ts:22:29 - error TS2339: Property 'GET /enterprises/{enterprise}/actions/runner-groups' does not exist on type 'Endpoints'.

22         response: Endpoints["GET /enterprises/{enterprise}/actions/runner-groups"]["response"] & {
                               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

node_modules/@octokit/plugin-paginate-rest/dist-types/generated/paginating-endpoints.d.ts:23:29 - error TS2339: Property 'GET /enterprises/{enterprise}/actions/runner-groups' does not exist on type 'Endpoints'.

23             data: Endpoints["GET /enterprises/{enterprise}/actions/runner-groups"]["response"]["data"]["runner_groups"];
                               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

node_modules/@octokit/plugin-paginate-rest/dist-types/generated/paginating-endpoints.d.ts:192:31 - error TS2339: Property 'GET /orgs/{org}/actions/runner-groups' does not exist on type 'Endpoints'.

192         parameters: Endpoints["GET /orgs/{org}/actions/runner-groups"]["parameters"];
                                  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

node_modules/@octokit/plugin-paginate-rest/dist-types/generated/paginating-endpoints.d.ts:193:29 - error TS2339: Property 'GET /orgs/{org}/actions/runner-groups' does not exist on type 'Endpoints'.

193         response: Endpoints["GET /orgs/{org}/actions/runner-groups"]["response"] & {
                                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

node_modules/@octokit/plugin-paginate-rest/dist-types/generated/paginating-endpoints.d.ts:194:29 - error TS2339: Property 'GET /orgs/{org}/actions/runner-groups' does not exist on type 'Endpoints'.

194             data: Endpoints["GET /orgs/{org}/actions/runner-groups"]["response"]["data"]["runner_groups"];
                                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

node_modules/@octokit/plugin-paginate-rest/dist-types/generated/paginating-endpoints.d.ts:201:31 - error TS2339: Property 'GET /orgs/{org}/actions/runner-groups/{runner_group_id}/repositories' does not exist on type 'Endpoints'.

201         parameters: Endpoints["GET /orgs/{org}/actions/runner-groups/{runner_group_id}/repositories"]["parameters"];
                                  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

node_modules/@octokit/plugin-paginate-rest/dist-types/generated/paginating-endpoints.d.ts:202:29 - error TS2339: Property 'GET /orgs/{org}/actions/runner-groups/{runner_group_id}/repositories' does not exist on type 'Endpoints'.

202         response: Endpoints["GET /orgs/{org}/actions/runner-groups/{runner_group_id}/repositories"]["response"] & {
                                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

node_modules/@octokit/plugin-paginate-rest/dist-types/generated/paginating-endpoints.d.ts:203:29 - error TS2339: Property 'GET /orgs/{org}/actions/runner-groups/{runner_group_id}/repositories' does not exist on type 'Endpoints'.

203             data: Endpoints["GET /orgs/{org}/actions/runner-groups/{runner_group_id}/repositories"]["response"]["data"]["repositories"];
                                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

node_modules/@octokit/plugin-paginate-rest/dist-types/generated/paginating-endpoints.d.ts:210:31 - error TS2339: Property 'GET /orgs/{org}/actions/runner-groups/{runner_group_id}/runners' does not exist on type 'Endpoints'.

210         parameters: Endpoints["GET /orgs/{org}/actions/runner-groups/{runner_group_id}/runners"]["parameters"];
                                  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

node_modules/@octokit/plugin-paginate-rest/dist-types/generated/paginating-endpoints.d.ts:211:29 - error TS2339: Property 'GET /orgs/{org}/actions/runner-groups/{runner_group_id}/runners' does not exist on type 'Endpoints'.

211         response: Endpoints["GET /orgs/{org}/actions/runner-groups/{runner_group_id}/runners"]["response"] & {
                                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

node_modules/@octokit/plugin-paginate-rest/dist-types/generated/paginating-endpoints.d.ts:212:29 - error TS2339: Property 'GET /orgs/{org}/actions/runner-groups/{runner_group_id}/runners' does not exist on type 'Endpoints'.

212             data: Endpoints["GET /orgs/{org}/actions/runner-groups/{runner_group_id}/runners"]["response"]["data"]["runners"];
                                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

node_modules/@octokit/plugin-rest-endpoint-methods/dist-types/generated/parameters-and-response-types.d.ts:1223:60 - error TS2339: Property 'POST /enterprises/{enterprise}/actions/runners/{runner_id}/labels' does not exist on type 'Endpoints'.

1223             parameters: RequestParameters & Omit<Endpoints["POST /enterprises/{enterprise}/actions/runners/{runner_id}/labels"]["parameters"], "baseUrl" | "headers" | "mediaType">;
                                                                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

node_modules/@octokit/plugin-rest-endpoint-methods/dist-types/generated/parameters-and-response-types.d.ts:1224:33 - error TS2339: Property 'POST /enterprises/{enterprise}/actions/runners/{runner_id}/labels' does not exist on type 'Endpoints'.

1224             response: Endpoints["POST /enterprises/{enterprise}/actions/runners/{runner_id}/labels"]["response"];
                                     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

node_modules/@octokit/plugin-rest-endpoint-methods/dist-types/generated/parameters-and-response-types.d.ts:1227:60 - error TS2339: Property 'PUT /enterprises/{enterprise}/actions/permissions/organizations/{org_id}' does not exist on type 'Endpoints'.

1227             parameters: RequestParameters & Omit<Endpoints["PUT /enterprises/{enterprise}/actions/permissions/organizations/{org_id}"]["parameters"], "baseUrl" | "headers" | "mediaType">;
                                                                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

node_modules/@octokit/plugin-rest-endpoint-methods/dist-types/generated/parameters-and-response-types.d.ts:1228:33 - error TS2339: Property 'PUT /enterprises/{enterprise}/actions/permissions/organizations/{org_id}' does not exist on type 'Endpoints'.

1228             response: Endpoints["PUT /enterprises/{enterprise}/actions/permissions/organizations/{org_id}"]["response"];
                                     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

node_modules/@octokit/plugin-rest-endpoint-methods/dist-types/generated/parameters-and-response-types.d.ts:1231:60 - error TS2339: Property 'GET /enterprises/{enterprise}/actions/runners/{runner_id}/labels' does not exist on type 'Endpoints'.

1231             parameters: RequestParameters & Omit<Endpoints["GET /enterprises/{enterprise}/actions/runners/{runner_id}/labels"]["parameters"], "baseUrl" | "headers" | "mediaType">;
                                                                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

node_modules/@octokit/plugin-rest-endpoint-methods/dist-types/generated/parameters-and-response-types.d.ts:1232:33 - error TS2339: Property 'GET /enterprises/{enterprise}/actions/runners/{runner_id}/labels' does not exist on type 'Endpoints'.

1232             response: Endpoints["GET /enterprises/{enterprise}/actions/runners/{runner_id}/labels"]["response"];
                                     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

node_modules/@octokit/plugin-rest-endpoint-methods/dist-types/generated/parameters-and-response-types.d.ts:3067:60 - error TS2339: Property 'GET /enterprises/{enterprise}/code_security_and_analysis' does not exist on type 'Endpoints'.

3067             parameters: RequestParameters & Omit<Endpoints["GET /enterprises/{enterprise}/code_security_and_analysis"]["parameters"], "baseUrl" | "headers" | "mediaType">;
                                                                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

node_modules/@octokit/plugin-rest-endpoint-methods/dist-types/generated/parameters-and-response-types.d.ts:3068:33 - error TS2339: Property 'GET /enterprises/{enterprise}/code_security_and_analysis' does not exist on type 'Endpoints'.

3068             response: Endpoints["GET /enterprises/{enterprise}/code_security_and_analysis"]["response"];
                                     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

node_modules/@octokit/plugin-rest-endpoint-methods/dist-types/generated/parameters-and-response-types.d.ts:3087:60 - error TS2339: Property 'PATCH /enterprises/{enterprise}/code_security_and_analysis' does not exist on type 'Endpoints'.

3087             parameters: RequestParameters & Omit<Endpoints["PATCH /enterprises/{enterprise}/code_security_and_analysis"]["parameters"], "baseUrl" | "headers" | "mediaType">;
                                                                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

node_modules/@octokit/plugin-rest-endpoint-methods/dist-types/generated/parameters-and-response-types.d.ts:3088:33 - error TS2339: Property 'PATCH /enterprises/{enterprise}/code_security_and_analysis' does not exist on type 'Endpoints'.

3088             response: Endpoints["PATCH /enterprises/{enterprise}/code_security_and_analysis"]["response"];
                                     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

node_modules/@octokit/plugin-rest-endpoint-methods/dist-types/generated/parameters-and-response-types.d.ts:3091:60 - error TS2339: Property 'POST /enterprises/{enterprise}/{security_product}/{enablement}' does not exist on type 'Endpoints'.

3091             parameters: RequestParameters & Omit<Endpoints["POST /enterprises/{enterprise}/{security_product}/{enablement}"]["parameters"], "baseUrl" | "headers" | "mediaType">;
                                                                ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

node_modules/@octokit/plugin-rest-endpoint-methods/dist-types/generated/parameters-and-response-types.d.ts:3092:33 - error TS2339: Property 'POST /enterprises/{enterprise}/{security_product}/{enablement}' does not exist on type 'Endpoints'.

3092             response: Endpoints["POST /enterprises/{enterprise}/{security_product}/{enablement}"]["response"];
                                     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~


Found 24 errors in 2 files.

Errors  Files
    12  node_modules/@octokit/plugin-paginate-rest/dist-types/generated/paginating-endpoints.d.ts:21
    12  node_modules/@octokit/plugin-rest-endpoint-methods/dist-types/generated/parameters-and-response-types.d.ts:1223
@tekumara tekumara added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels May 6, 2023
@tekumara
Copy link
Author

tekumara commented May 6, 2023

Looks like an upstream issue, see octokit/rest.js#290

@ben-foxmoore
Copy link
Contributor

ben-foxmoore commented May 8, 2023

@cdata This temporary change at least allowed me to run the tests included in this repo:

diff --git a/package.json b/package.json
index d7a0ff8..2bc0b36 100644
--- a/package.json
+++ b/package.json
@@ -38,7 +38,7 @@
     }
   },
   "devDependencies": {
-    "@octokit/types": "^9.0.0",
+    "@octokit/types": "9.0.0",
     "@types/chai": "^4.1.7",
     "@types/diff": "^5.0.2",
     "@types/iarna__toml": "^2.0.1",
@@ -104,5 +104,9 @@
   },
   "engines": {
     "node": ">=14.0.0"
+  },
+  "overrides": {
+    "@octokit/types": "9.0.0",
+    "@octokit/openapi-types": "16.0.0"
   }
 }

@cdata
Copy link
Contributor

cdata commented May 8, 2023

Thanks @ben-foxmoore looks like I'm up and running now 🙌

@chingor13 chingor13 closed this as not planned Won't fix, can't repro, duplicate, stale Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

No branches or pull requests

4 participants