Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adds metadata versioning for terraform modules #2041

Merged
merged 6 commits into from
Aug 18, 2023

Conversation

g-awmalik
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #2040

@g-awmalik g-awmalik requested review from a team as code owners August 9, 2023 17:32
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Aug 9, 2023
@g-awmalik
Copy link
Contributor Author

@bcoe - please review when you get a chance.

Copy link
Contributor

@bcoe bcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit, I think the logic can be simplified slightly.

Also, I left a question about the findFilesByFilenameAndRef method, it would be good to confirm that it returns an empty array if no results are found.

src/strategies/terraform-module.ts Outdated Show resolved Hide resolved
src/strategies/terraform-module.ts Outdated Show resolved Hide resolved
test/updaters/metadata.ts Show resolved Hide resolved
@g-awmalik
Copy link
Contributor Author

One nit, I think the logic can be simplified slightly.

Also, I left a question about the findFilesByFilenameAndRef method, it would be good to confirm that it returns an empty array if no results are found.

PTAL.

@g-awmalik g-awmalik requested a review from bcoe August 16, 2023 23:50
@bcoe bcoe merged commit 49b33c7 into googleapis:main Aug 18, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include metadata.yaml files for terraform modules version bumps
3 participants