Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Use default updaters based on file extension #2072

Merged
merged 5 commits into from
Sep 18, 2023
Merged

feat: Use default updaters based on file extension #2072

merged 5 commits into from
Sep 18, 2023

Conversation

regseb
Copy link
Contributor

@regseb regseb commented Sep 12, 2023 •
edited
Loading

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #2067

@regseb regseb requested review from a team as code owners September 12, 2023 08:20
@google-cla
Copy link

google-cla bot commented Sep 12, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Sep 12, 2023
chingor13
chingor13 requested changes Sep 12, 2023
View reviewed changes
Copy link
Contributor

@chingor13 chingor13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this and it seems reasonable as long as we can avoid breaking existing users.

src/strategies/base.ts Outdated Show resolved Hide resolved
chingor13
chingor13 reviewed Sep 12, 2023
View reviewed changes
src/strategies/base.ts Outdated Show resolved Hide resolved
chingor13
chingor13 approved these changes Sep 18, 2023
View reviewed changes
Copy link
Contributor

@chingor13 chingor13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@chingor13 chingor13 merged commit 1ee162b into googleapis:main Sep 18, 2023
10 checks passed
@release-please release-please bot mentioned this pull request Sep 18, 2023
Merged
kalosisz added a commit to kalosisz/release-please that referenced this pull request Sep 19, 2023
@kalosisz
docs
92b83d8 
chore(deps): update actions/checkout action to v4 (googleapis#2060)

docs: check `autorelease: pending` or `autorelease: triggered` in an old PR (googleapis#1930)

* docs: check `autorelease: pending` or `autorelease: triggered` in an old PR

In googleapis/java-logging-logback#1050, I had to remove the "autorelease: pending " label to create a release pull request.

* Update README.md

fix mismerge

---------

Co-authored-by: Jeff Ching <chingor@google.com>

test: also test on node 18 (googleapis#2063)

* test: also test on node 18

* ci: enable no-experimental-fetch for tests

* ci: set NODE_OPTIONS for node 18

* set NODE_OPTIONS for windows build

* set NODE_OPTIONS for windows build

ci: only require node 18 tests (googleapis#2065)

feat!: require node 18+ (googleapis#2069)

fix(deps): bump semver dependency version (googleapis#2068)

feat: Support pnpm workspaces (googleapis#2058)

fix(deps): replace lerna dependency with lerna-lite

Co-authored-by: Jeff Ching <chingor@google.com>

fix(deps): upgrade http-proxy-agent to v7 (googleapis#2071)

fix(deps): upgrade https-proxy-agent to v7

feat: fallback to root package version if package ignores github release (googleapis#1935)

Co-authored-by: Jeff Ching <chingor@google.com>

chore(deps): update dependency sinon to v16 (googleapis#2079)

feat: Use default updaters based on file extension (googleapis#2072)

* feat: Use default updaters based on file extension

* use CompositeUpdater

* improve things

---------

Co-authored-by: Jeff Ching <chingor@google.com>

chore(main): release 16.0.0 (googleapis#2070)

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

config

docs
kalosisz added a commit to kalosisz/release-please that referenced this pull request Sep 19, 2023
@kalosisz
docs
3e11950 
chore(deps): update actions/checkout action to v4 (googleapis#2060)

docs: check `autorelease: pending` or `autorelease: triggered` in an old PR (googleapis#1930)

* docs: check `autorelease: pending` or `autorelease: triggered` in an old PR

In googleapis/java-logging-logback#1050, I had to remove the "autorelease: pending " label to create a release pull request.

* Update README.md

fix mismerge

---------

Co-authored-by: Jeff Ching <chingor@google.com>

test: also test on node 18 (googleapis#2063)

* test: also test on node 18

* ci: enable no-experimental-fetch for tests

* ci: set NODE_OPTIONS for node 18

* set NODE_OPTIONS for windows build

* set NODE_OPTIONS for windows build

ci: only require node 18 tests (googleapis#2065)

feat!: require node 18+ (googleapis#2069)

fix(deps): bump semver dependency version (googleapis#2068)

feat: Support pnpm workspaces (googleapis#2058)

fix(deps): replace lerna dependency with lerna-lite

Co-authored-by: Jeff Ching <chingor@google.com>

fix(deps): upgrade http-proxy-agent to v7 (googleapis#2071)

fix(deps): upgrade https-proxy-agent to v7

feat: fallback to root package version if package ignores github release (googleapis#1935)

Co-authored-by: Jeff Ching <chingor@google.com>

chore(deps): update dependency sinon to v16 (googleapis#2079)

feat: Use default updaters based on file extension (googleapis#2072)

* feat: Use default updaters based on file extension

* use CompositeUpdater

* improve things

---------

Co-authored-by: Jeff Ching <chingor@google.com>

chore(main): release 16.0.0 (googleapis#2070)

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

config

docs
@regseb regseb deleted the updaters branch October 2, 2023 16:46
@jooola jooola mentioned this pull request Dec 19, 2023
Merged
@LoicFerrot LoicFerrot mentioned this pull request Jan 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chingor13 chingor13 chingor13 approved these changes

Assignees

@chingor13 chingor13

Labels
size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create default updaters for each language based on file extension
2 participants
@regseb @chingor13