Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: customize PR body footer #2115

Merged
merged 4 commits into from
Nov 6, 2023
Merged

feat: customize PR body footer #2115

merged 4 commits into from
Nov 6, 2023

Conversation

rozsazoltan
Copy link
Contributor

The function already exists, but it cannot be changed as a parameter for package users. This update makes the setting available to everyone.

The pull-request-footer option has been added to the configuration file. When tracked, it completely matches the settings of the pull-request-header. The PR generator was already equipped with a footer parameter by default, so you just need to pass this setting along.

Fixes #2114 🦕

The function already exists, but it cannot be changed as a parameter for package users. This update makes the setting available to everyone.
@rozsazoltan rozsazoltan requested review from a team as code owners November 6, 2023 13:13
Copy link

google-cla bot commented Nov 6, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Nov 6, 2023
Copy link
Contributor

@chingor13 chingor13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Looks good to me except for the formatting which can be fixed with npm run fix.

@chingor13 chingor13 merged commit 43014a1 into googleapis:main Nov 6, 2023
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Customize PR body footer
2 participants