Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correctly parse standalone prerelease PR body #2123

Merged

Conversation

lukekarrys
Copy link
Contributor

@lukekarrys lukekarrys commented Nov 7, 2023

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕


This fixes pull request body parsing for single prereleases. Previously the regex used to match the title would include the rest of the title link as well. This PR changes the regex to match everything up until the next ].

Here's the output of the new test without this change:

AssertionError: expected '3.2.7-pre.0](https://www.github.com/g…' to deeply equal '3.2.7-pre.0'
+ expected - actual

-3.2.7-pre.0](https://www.github.com/googleapis/java-asset/compare/v3.2.6...v3.2.7-pre.0) (2021-10-20)
+3.2.7-pre.0

@lukekarrys lukekarrys requested review from a team as code owners November 7, 2023 21:52
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Nov 7, 2023
Copy link
Contributor

@chingor13 chingor13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@chingor13 chingor13 merged commit 5ee9e3e into googleapis:main Nov 8, 2023
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants