Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge plugin does not use pull-request-header and pull-request-footer config values #2142

Closed
lukekarrys opened this issue Nov 27, 2023 · 0 comments · Fixed by #2143
Closed

Merge plugin does not use pull-request-header and pull-request-footer config values #2142

lukekarrys opened this issue Nov 27, 2023 · 0 comments · Fixed by #2143
Assignees
@chingor13
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@lukekarrys
Copy link
Contributor

Environment details

  • OS: Darwin pieholden-m1.local 23.1.0 Darwin Kernel Version 23.1.0: Mon Oct 9 21:28:12 PDT 2023; root:xnu-10002.41.9~6/RELEASE_ARM64_T8103 arm64 arm Darwin
  • Node.js version: 20.7.0
  • npm version: 10.2.3
  • release-please version: 16.3.0

Steps to reproduce

  1. Set pull-request-header and pull-request-footer to any string value
  2. Set separate-pull-requests to false
  3. Use release-please to create a PR with multiple components
  4. Observe that the default header and footer are part of the PR

Making sure to follow these steps will guarantee the quickest resolution possible.

Thanks!
@lukekarrys lukekarrys added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Nov 27, 2023
@lukekarrys lukekarrys mentioned this issue Nov 27, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chingor13 chingor13

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: pass pull request header and footer options to merge plugin lukekarrys/release-please
2 participants
@chingor13 @lukekarrys