Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Node Monorepo - Root package-lock.json #2161

Closed
tada5hi opened this issue Dec 11, 2023 · 1 comment · Fixed by #2162
Closed

Node Monorepo - Root package-lock.json #2161

tada5hi opened this issue Dec 11, 2023 · 1 comment · Fixed by #2162
Assignees
@chingor13
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@tada5hi
Copy link
Contributor

tada5hi commented Dec 11, 2023 •
edited
Loading

Environment details

  • OS: Ubunutu 22.04.3
  • Node.js version: 18.18.0
  • npm version: 9.8.1
  • release-please version: 16.4.0

Steps to reproduce

  1. create a nodejs/npm monorepo
  2. create release please manifest + config
  3. inspect pull request of release please bot

The problem is that release-please only tries to update the lock file in the local package folder (e.g. packages/package-a/package-lock.json), but not the root lock file.

In the following pull request https://github.com/authup/authup/pull/1566/files, for example, I would assume that the version of the respective package that is to be updated is also updated in the root package-lock.json file
@tada5hi tada5hi added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Dec 11, 2023
@tada5hi tada5hi mentioned this issue Dec 11, 2023
Merged
4 tasks
@tada5hi
Copy link
Contributor Author

tada5hi commented Dec 11, 2023

@bcoe maybe you can take a look at that too. Thank you very much for your time

@blaine-arcjet blaine-arcjet mentioned this issue Dec 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chingor13 chingor13

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add root package-lock.json support tada5hi/release-please
2 participants
@chingor13 @tada5hi