Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: old version range detection #2171

Merged
merged 1 commit into from
Dec 18, 2023
Merged

fix: old version range detection #2171

merged 1 commit into from
Dec 18, 2023

Conversation

tada5hi
Copy link
Contributor

@tada5hi tada5hi commented Dec 17, 2023

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #2170 🦕

@tada5hi tada5hi requested review from a team as code owners December 17, 2023 10:43
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Dec 17, 2023
chingor13
chingor13 approved these changes Dec 18, 2023
View reviewed changes
Copy link
Contributor

@chingor13 chingor13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@chingor13 chingor13 merged commit 47fe582 into googleapis:main Dec 18, 2023
11 checks passed
@release-please release-please bot mentioned this pull request Dec 15, 2023
Merged
@tada5hi
Copy link
Contributor Author

tada5hi commented Dec 18, 2023

@chingor13 your welcome! ☺️✌️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chingor13 chingor13 chingor13 approved these changes

Assignees

@chingor13 chingor13

Labels
size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Package.json old version range detection
2 participants
@tada5hi @chingor13