feat: set 'version' of composer.json in RootComposerUpdatePackages #2201
+52
−23
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses #2198
Marked as a
feat
since it changes the behavior ofRootComposerUpdatePackage
by always updatingversion
incomposer.json
.IMPORTANT: The behavior of the php strategy (
src/strategies/php.ts
) will not change, asversion
was already being set in theversionsMap
. The only difference in the php strategy is in the case wherecomposer.json
includes areplace
section: the "version" key will no longer be added to it. This is the desired behavior, as adding such a string toreplace
results in a composer exception.