Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support BEGIN_VERSION_OVERRIDE in php-yoshi #2300

Merged
merged 2 commits into from
Jun 6, 2024
Merged

feat: support BEGIN_VERSION_OVERRIDE in php-yoshi #2300

merged 2 commits into from
Jun 6, 2024

Conversation

bshaffer
Copy link
Contributor

@bshaffer bshaffer commented Jun 4, 2024 •
edited
Loading

Allow for adding BEGIN_VERSION_OVERRIDE to PHP release in order to override the release version from the PR for specific components.

Example PR body:

// normal PR body (from owlbot or otherwise)

// at the end of the PR

BEGIN_VERSION_OVERRIDE
PubSub: 2.0.0-RC1
Core: 1.45.0
END_VERSION_OVERRIDE

@bshaffer bshaffer requested review from a team as code owners June 4, 2024 21:55
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Jun 4, 2024
@bshaffer bshaffer mentioned this pull request Jun 5, 2024
Merged
@chingor13 chingor13 merged commit b9d4544 into main Jun 6, 2024
17 checks passed
@chingor13 chingor13 deleted the add-php-release-as branch June 6, 2024 16:24
@release-please release-please bot mentioned this pull request Jun 6, 2024
Merged
@bshaffer bshaffer mentioned this pull request Jun 6, 2024
Closed
@bshaffer bshaffer mentioned this pull request Jul 8, 2024
Merged
@WontonSam WontonSam mentioned this pull request Sep 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chingor13 chingor13 chingor13 approved these changes

Assignees

@chingor13 chingor13

Labels
size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bshaffer @chingor13