Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Existing, unmerged PR is preventing release-please from finding last release #2322

Closed
stdavis opened this issue Jun 26, 2024 · 0 comments · Fixed by #2323
Closed

Existing, unmerged PR is preventing release-please from finding last release #2322

stdavis opened this issue Jun 26, 2024 · 0 comments · Fixed by #2323
Assignees
@chingor13
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@stdavis
Copy link
Contributor

stdavis commented Jun 26, 2024

Thanks for stopping by to let us know something could be better!

Please provide the following details.

Environment details

  • OS: Ubuntu 22.04.4 ubuntu-latest via GitHub Actions
  • Node.js version: 20.14.0
  • npm version: 10.7.0
  • release-please version: 16.12.0

Steps to reproduce

  1. Run release-please release-pr once to create a release PR.
  2. Run it again and notice how the changelog includes all of the changes since the beginning of the commit history; not just the ones since the last release.

Here is an example run in GitHub actions: https://github.com/agrc/release-composite-action/actions/runs/9682337676/job/26716885320

And here is the PR that it updated: agrc/release-composite-action#76

It should only show the following changelog:
image
@stdavis stdavis added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Jun 26, 2024
@stdavis stdavis mentioned this issue Jun 26, 2024
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chingor13 chingor13

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: prevent open release PRs from being mistaken as current releases stdavis/release-please
2 participants
@chingor13 @stdavis