Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the creation of prereleases above v1.0 #2335

Open
henworth opened this issue Jul 11, 2024 · 1 comment
Open

Allow the creation of prereleases above v1.0 #2335

henworth opened this issue Jul 11, 2024 · 1 comment
Assignees
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@henworth
Copy link

Thanks for stopping by to let us know something could be better!

Is your feature request related to a problem? Please describe.

Currently it seems creating prerelease versions above 1.0 are not allowed. I believe this line is responsible for preventing that. I'm curious if this is intended or if the maintainers would be willing to allow this behavior.

My workflow creates a prerelease for integration testing, for which a image is built and pushed to that environment. Once those tests are successful we promote it by changing the GitHub prerelease to a full release. This process worked fine until a repo reached v1.0.0 after which I observed Release Please was no longer creating prereleases and pipelines started breaking.

Describe the solution you'd like

Provide a way for Release Please to respect prerelease: true irrespective of the released version.

Describe alternatives you've considered

I have considered a prerelease versioning strategy, but that would require extra effort to add and remove versioning strings or relabel container images. That very well might work but is less clean (in my opinion) than what was previously working just fine.

Additional context

None.

@henworth henworth added priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Jul 11, 2024
@maximzavadskiy
Copy link

maximzavadskiy commented Jul 16, 2024

Seems to work for me using CLI at least, just created [chore(main): release release-please 2.0.0-rc](https://github.com/maximzavadskiy/test-release-please/actions/runs/9959384646)

release-please-config.json:

{
  "packages": {
    ".": {
      "changelog-path": "CHANGELOG.md",
      "release-type": "node",
      "prerelease-type": "rc",
      "bump-minor-pre-major": false,
      "bump-patch-for-minor-pre-major": false,
      "draft": false,
      "prerelease": true,
      "versioning": "prerelease"
    }
  },
  "$schema": "https://raw.githubusercontent.com/googleapis/release-please/main/schemas/config.json"
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

No branches or pull requests

3 participants