Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How would i update the image tag using extra-files #2340

Closed
stecullum opened this issue Jul 22, 2024 · 1 comment · Fixed by #2344
Closed

How would i update the image tag using extra-files #2340

stecullum opened this issue Jul 22, 2024 · 1 comment · Fixed by #2344
Assignees
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: question Request for information or clarification. Not an issue.

Comments

@stecullum
Copy link

stecullum commented Jul 22, 2024

Using extra-files how can i update the tag value for an image with a prefix eg "app-0.0.1" instead of just "0.0.1"

Thanks

"packages": {
    "app": {
      "release-type": "simple",
      "package-name": "app",
      "extra-files": [
        {
          "type": "yaml",
          "path": "test.yaml",
          "jsonpath": "$./spec/values/image/tag"
        }
      ]
    },

and the target of..

apiVersion: helm.toolkit.fluxcd.io/v2beta1
kind: HelmRelease
spec:
 values:
   replicaCount: 1 # there is only ever one allowed to run at once 
   image:
     name: "app"
     tag: "app-0.0.0"
@stecullum stecullum added priority: p3 Desirable enhancement or fix. May not be included in next release. type: question Request for information or clarification. Not an issue. labels Jul 22, 2024
@stecullum
Copy link
Author

stecullum commented Jul 25, 2024

Found there is a "generic" type in extra-files but its not in the schema.
The following works for me

    image:
      name: "myapp"
      repository: foo
      tag: app-0.0.0 # x-release-please-version
"packages": {
    "/src/myapp": {  
       "extra-files": [
          {
            "type": "generic",
            "path": "/path_under_src_myapp/my.yaml"
          }
        ]
    ...
      "$schema": "https://raw.githubusercontent.com/googleapis/release-please/main/schemas/config.json"

I could not find the type "generic" in the schema ..
https://github.com/googleapis/release-please/blob/main/schemas/config.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: question Request for information or clarification. Not an issue.
Projects
None yet
2 participants