Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple commit messages being parsed from dependabot commit message #2392

Closed
chingor13 opened this issue Oct 1, 2024 · 0 comments · Fixed by #2390
Closed

Multiple commit messages being parsed from dependabot commit message #2392

chingor13 opened this issue Oct 1, 2024 · 0 comments · Fixed by #2390
Assignees
@chingor13
Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@chingor13
Copy link
Contributor

Example: googleapis/release-please-action#1033 is parsing sub-commit messages incorrectly from googleapis/release-please-action@b2a986c

handle multiple commits in a single message (<a ([b2a986c](https://github.com/googleapis/release-please-action/commit/b2a986c7e2f041e21005c546b2e03e9722e45bad))

When parsing multiple messages from a single commit, we should look for an extra space between lines
@chingor13 chingor13 added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels Oct 1, 2024
@chingor13 chingor13 self-assigned this Oct 1, 2024
@chingor13 chingor13 mentioned this issue Oct 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chingor13 chingor13

Labels
priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
1 participant
@chingor13