Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic updater: x-release-please-major does not match strings prefixed with 'v' (e.g., 'v<major>') #2421

Open
faradayfan opened this issue Nov 6, 2024 · 0 comments · May be fixed by #2422
Assignees
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@faradayfan
Copy link

Generic updater: x-release-please-major does not match strings prefixed with 'v' (e.g., 'v')

Environment details

  • Encountered in the release-please-action@v4
  • release-please version: 16.12.0

Steps to reproduce

When annotating a file with x-release-please-major like this:

Major: 2 # x-release-please-major
Major with v: v2 # x-release-please-major

The result is the following update:

Major: 3 # x-release-please-major
Major with v: v2 # x-release-please-major

The expected output is:

Major: 3 # x-release-please-major
Major with v: v3 # x-release-please-major

Looking at the generic updater code, this appears to be directly caused by the regex used for single version updates. It looking for a preceding word boundary, which in this case there is none.

I was unable to find documentation on why this is a desired behavior, or is this was fixed in a more recent version.

@faradayfan faradayfan added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Nov 6, 2024
@faradayfan faradayfan linked a pull request Nov 6, 2024 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants