Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore PR Not Created for PR 1 When PR 1 is Merged After PR 2 #2441

Open
Hallocoos opened this issue Nov 22, 2024 · 0 comments
Open

Chore PR Not Created for PR 1 When PR 1 is Merged After PR 2 #2441

Hallocoos opened this issue Nov 22, 2024 · 0 comments
Assignees
@chingor13
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@Hallocoos
Copy link

Environment details

  • OS: Windows 10, WSL Ubuntu
  • Node.js version: actions/setup-node@v3 uses 18.20.2
  • npm version: default
  • release-please version: google-github-actions/release-please-action@v3

Steps to reproduce

  1. PR 1 is created.
  2. PR 2 is created.
  3. PR 2 is approved and merged into main.
  4. Chore for PR 2 is created.
  5. PR 1 is merged in.
  6. No Chore for PR 1 is created.

My colleagues and I suspect that a desync of some kind is happening when someone else creates a PR after you created one and they merge their PR in before you merge yours in.

It causes issue, as obviously, not all PR's have the same scope or size. So a small and quick hotfix, prevents all currently open PR's from creating a Please Release Chore PR for some reason.
@Hallocoos Hallocoos added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chingor13 chingor13

Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chingor13 @Hallocoos