Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github Release and tag is not created when merging the release PR using the Github CLI #2457

Open
nils1k opened this issue Dec 20, 2024 · 0 comments
Assignees
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@nils1k
Copy link

nils1k commented Dec 20, 2024

Describe the error

Neither a tag, nor a release, is being created when merging the release PR using the Github CLI.

Steps to reproduce

  1. Push a commit so that a release PR is generated
  2. Merge the PR manually so that a release and tag are created
  3. Push a commit so that a new release PR is generated
  4. Use the Github CLI to merge the release PR, e.g. gh pr merge <pr_number> --squash
  5. The release PR is merged, but neither a release, nor a tag, is a created

Please refer to the sample code that reproduces the issue.

Workaround

A workaround seems to be to add the release-please:force-run label to the merged PR, as suggested in the README.

Notes

This issue was originally posted in the release-please-action repository, but I'm posting it here as well as I'm unsure about where the issue belongs.

@nils1k nils1k added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Development

No branches or pull requests

2 participants