Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: conventional commit for JavaApiaryCodegen #4356

Merged
merged 7 commits into from
Sep 8, 2022
Merged

fix: conventional commit for JavaApiaryCodegen #4356

merged 7 commits into from
Sep 8, 2022

Conversation

meltsufin
Copy link
Member

Fixes: #4355.

@meltsufin meltsufin requested a review from a team September 8, 2022 01:05
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Sep 8, 2022
@meltsufin
Copy link
Member Author

Note that I haven't tested this at all.

suztomo
suztomo approved these changes Sep 8, 2022
View reviewed changes
Copy link
Member

@suztomo suztomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for following this through.

@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Sep 8, 2022
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. and removed size: s Pull request size is small. labels Sep 8, 2022
chingor13
chingor13 approved these changes Sep 8, 2022
View reviewed changes
Copy link
Contributor

@chingor13 chingor13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the test improvement too!

@chingor13 chingor13 merged commit c732259 into googleapis:main Sep 8, 2022
@release-please release-please bot mentioned this pull request Aug 21, 2023
Closed
@release-please release-please bot mentioned this pull request Sep 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chingor13 chingor13 chingor13 approved these changes

@suztomo suztomo suztomo approved these changes

Assignees

@bcoe bcoe

Labels
size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

JavaApiaryCodegen auto-merge not working with conventional commits
4 participants
@meltsufin @suztomo @chingor13 @bcoe