Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable nested commit feature for owlbot copy-code PRs #4535

Closed
chingor13 opened this issue Oct 5, 2022 · 3 comments · Fixed by #4619
Closed

Enable nested commit feature for owlbot copy-code PRs #4535

chingor13 opened this issue Oct 5, 2022 · 3 comments · Fixed by #4619
Assignees
@SurferJeffAtGoogle
Labels
bot: owl-bot priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@chingor13
Copy link
Contributor

We would like to enable the BEGIN_NESTED_COMMIT markers for owlbot copy-code PRs (at least for Java). Is there a way to enable this partially or run locally to try out the flag.

The feature was implemented in #4426
@chingor13 chingor13 added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Oct 5, 2022
@SurferJeffAtGoogle
Copy link
Contributor

@chingor13 Can we close this issue now?

@chingor13
Copy link
Contributor Author

Yes, this was enabled in #4539

@chingor13 chingor13 reopened this Oct 24, 2022
@chingor13
Copy link
Contributor Author

Looks like this may not be enabled

This was referenced Oct 24, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SurferJeffAtGoogle SurferJeffAtGoogle

Labels
bot: owl-bot priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: enable nested commit delimiters googleapis/repo-automation-bots
2 participants
@chingor13 @SurferJeffAtGoogle