Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pass context logger to post-processor handlers #4957

Merged
merged 2 commits into from
Jan 26, 2023

Conversation

chingor13
Copy link
Contributor

@chingor13 chingor13 commented Jan 24, 2023

While debugging #4946, I found that many logs are incorrectly attributed due to using importing the default GCFLogger rather than injecting an instance with request context. When we import the shared one, the context can be incorrect because the instance is shared between concurrent requests.

@chingor13 chingor13 enabled auto-merge (squash) January 26, 2023 05:29
@chingor13 chingor13 merged commit 9512ff5 into main Jan 26, 2023
@chingor13 chingor13 deleted the owlbot-postprocessor-logging-context branch January 26, 2023 05:31
@release-please release-please bot mentioned this pull request Aug 21, 2023
@release-please release-please bot mentioned this pull request Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants