feat(blunderbuss): assign_prs_always in config #5051
Conversation
| - java-samples-reviewers | ||
| assign_prs: | ||
| - prs1 | ||
| assign_prs_always: |
There was a problem hiding this comment.
Rather than introducing an additional assign_prs_always which seems a little redundant given that we have assign_prs, what if you instead introduce:
assignment_config:
apply_all_pr_rules: true
Or something like this.
There was a problem hiding this comment.
If apply_all_pr_rules was set to true, it implies we should apply both assign_prs_by and assign_prs.
There was a problem hiding this comment.
I prefer @amanda-tarafa's proposal. What does @amanda-tarafa say?
There was a problem hiding this comment.
I also prefer my own proposal (haha) because it means that assign_prs can act as a fallback for assign_prs_by regardless of whether assign_prs_always is set. For instance, for products whose samples don't have an owner (i.e. we don't have an assign_prs_by), we still need two reviews, so we still need two assignees. We would get one from assign_prs (as a fallback for assign_prs_by) and one from assign_prs_always.
There was a problem hiding this comment.
I prefer my proposal, but am outvoted 😝 . Approved!
Fixes #5043