fix(auto-approve): update regex for Node #5064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chingor13
requested changes
May 18, 2023
| titleRegex: /^(fix|chore)\(deps\): update dependency (@?\S*) to v(\S*)$/, | ||
| titleRegex: | ||
| // This would match: fix(deps): update dependency @octokit/rest to v19.0.8 or ^0.23.0 or ~0.23.0 | ||
| /^(fix|chore)\(deps\): update dependency (@?\S*) to v?\^?~?(\S*)$/, |
There was a problem hiding this comment.
If we know there's at least one of v, ^, or ~, put it in a character group:
Suggested change
| /^(fix|chore)\(deps\): update dependency (@?\S*) to v?\^?~?(\S*)$/, | |
| /^(fix|chore)\(deps\): update dependency (@?\S*) to [v\^~](\S*)$/, |
There was a problem hiding this comment.
I don't think we know for sure, although I haven't seen it without one of those yet. But I think it would be safer the way I have it, since then we could just accept the number, for example:
fix(deps): update dependency recast to 0.23.0
This would be a valid configuration, since the ^ and ~ are just accepting larger ranges, which don't necessarily have to be the case.
chingor13
approved these changes
May 23, 2023
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some strange PRs have prompted looking into the pattern being used.