Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use http/1.1 for post #5067

Merged
merged 4 commits into from
May 24, 2023
Merged

fix: use http/1.1 for post #5067

merged 4 commits into from
May 24, 2023

Conversation

bcoe
Copy link
Contributor

@bcoe bcoe commented May 24, 2023

Attempt the resolution documented here for RPC failed; HTTP 408 curl 18 HTTP/2 stream 7 was reset.

Fixes #5066

@bcoe bcoe requested a review from a team as a code owner May 24, 2023 15:52
Copy link
Contributor

@chingor13 chingor13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should put this in the owlbot-cli Dockerfile as it's a global config

@@ -33,6 +33,28 @@ steps:
- --global
- user.name
- 'Owl Bot'
# TODO: remove when we find a better resolution.
# See: https://github.com/orgs/community/discussions/55820
- name: 'gcr.io/cloud-builders/git'
Copy link
Contributor

@chingor13 chingor13 May 24, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this method is going to work. GCB only shares the /workspace directory between steps (or possibly other folders if you explicitly share). git config --global commands puts config in your ~/.git/config.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the git push happens in the CLI command not in the docker container:

https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/src/copy-code.ts#L817

packages/owl-bot/Dockerfile Outdated Show resolved Hide resolved
packages/owl-bot/Dockerfile Outdated Show resolved Hide resolved
@chingor13 chingor13 merged commit a865295 into main May 24, 2023
@chingor13 chingor13 deleted the temp-fix-for-post-size branch May 24, 2023 16:12
@release-please release-please bot mentioned this pull request Aug 21, 2023
@release-please release-please bot mentioned this pull request Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

owlbot hitting commit size limit
2 participants