-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use http/1.1 for post #5067
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should put this in the owlbot-cli Dockerfile as it's a global config
@@ -33,6 +33,28 @@ steps: | |||
- --global | |||
- user.name | |||
- 'Owl Bot' | |||
# TODO: remove when we find a better resolution. | |||
# See: https://github.com/orgs/community/discussions/55820 | |||
- name: 'gcr.io/cloud-builders/git' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this method is going to work. GCB only shares the /workspace
directory between steps (or possibly other folders if you explicitly share). git config --global
commands puts config in your ~/.git/config
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe the git push happens in the CLI command not in the docker container:
Attempt the resolution documented here for
RPC failed; HTTP 408 curl 18 HTTP/2 stream 7 was reset
.Fixes #5066