feat: add Java sample app dependency #5153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sofisl
changed the title
sofisl
changed the title
|
@chingor13 is a better reviewer, given my calendar this week. Thanks for this awesome work supporting @bourgeoisor! |
sofisl
changed the title
chingor13
approved these changes
Jul 19, 2023
| incomingPR.title | ||
| ); | ||
|
|
||
| const isVersionValid = runVersioningValidation(versions); |
There was a problem hiding this comment.
It would still be nice to do the refactor we had planned or at least make this more readable. It's hard to tell at a glance what this is validating.
| @@ -0,0 +1,171 @@ | |||
| // Copyright 2023 Google LLC | |||
There was a problem hiding this comment.
nit: the file name should match the class name better - it would help make it easier to discover where the class is defined.
sofisl
changed the title
Closed
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5098