Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support strict escaping requirements for REST query parameters #1187

Open
burkedavison opened this issue Dec 21, 2022 · 2 comments
Open

Support strict escaping requirements for REST query parameters #1187

burkedavison opened this issue Dec 21, 2022 · 2 comments
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. status: blocked Resolving the issue is dependent on other work. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@burkedavison
Copy link
Member

burkedavison commented Dec 21, 2022 •
edited
Loading

Showcase REST integration tests are written to expect the showcase server to throw an IllegalArgumentException until the query parameters meet a more strict set of requirements as defined here:

https://github.com/googleapis/gapic-showcase/blob/v0.25.0/util/genrest/resttools/systemparam.go#L37-L46

This issue is referenced in a TODO in the showcase BUILD.bazel file. To replicate, enable numeric enums and see DEVELOPMENT.md for how to run the showcase integration tests.
@burkedavison burkedavison added type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. priority: p2 Moderately-important priority. Fix may not be included in next release. labels Dec 21, 2022
@blakeli0 blakeli0 added the status: blocked Resolving the issue is dependent on other work. label Dec 22, 2022
@burkedavison burkedavison changed the title Support strict escaping requirements for HTTP query parameters Support strict escaping requirements for REST query parameters Jan 24, 2023
@mpeddada1 mpeddada1 mentioned this issue Jan 27, 2023
Open
@blakeli0
Copy link
Collaborator

This issue is blocked until googleapis/gapic-showcase#1255 is fixed. Based the latest comment, Victor will into it.

@blakeli0
Copy link
Collaborator

Downgrading to P3 as we can do vast majority of showcase tests without this fix.

@blakeli0 blakeli0 added priority: p3 Desirable enhancement or fix. May not be included in next release. and removed priority: p2 Moderately-important priority. Fix may not be included in next release. labels Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. status: blocked Resolving the issue is dependent on other work. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@blakeli0 @burkedavison