Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix release tag workflow to fetch all tags first #1700

Merged
merged 1 commit into from
May 24, 2023
Merged

Conversation

alicejli
Copy link
Contributor

Hopefully final follow-up to: #1699

Workflow currently fails if tag is already created. This is because the actions/checkout checks out the code in a fresh workspace that does not contain tags by default. This adds in the step of fetching tags.

@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label May 23, 2023
Copy link
Member

@suztomo suztomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternatively we can make it override old tags. Either handling is fine, because I don't expect this workflow to run against an old release.

@suztomo suztomo added the owlbot:run Add this label to trigger the Owlbot post processor. label May 24, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 24, 2023
@suztomo suztomo added automerge Merge the pull request once unit tests and other checks pass. owlbot:run Add this label to trigger the Owlbot post processor. labels May 24, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 24, 2023
@suztomo
Copy link
Member

suztomo commented May 24, 2023

@mpeddada1 This change doesn't affect the release. This is just an error handling in case there's existing tags.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label May 24, 2023
@sonarcloud
Copy link

sonarcloud bot commented May 24, 2023

[gapic-generator-java-root] Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@alicejli alicejli marked this pull request as ready for review May 24, 2023 14:22
@alicejli alicejli requested a review from a team as a code owner May 24, 2023 14:22
@alicejli alicejli merged commit 99b0c96 into main May 24, 2023
@alicejli alicejli deleted the fixWorkflow branch May 24, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants