feat: gapic-generator-java to perform a no-op when no services are detected #2460
Conversation
diegomarquezp
changed the title
product-auto-label
bot
added
size: m
|
Throwing an exception and catch it just to perform no-op and/or logging is not a good practice. It would be better if we can do the same thing gracefully. For example, can we remove this check, log the scenario, and return an empty |
… into gapic-generator-no-service-noop
I confirmed they pass locally. Not sure how to prove it in a PR that updates both the generator and the hermetic build scripts Reason: the hermetic build IT uses a published GGJ instead of compiling its own EDIT: I decided to move all |
That sounds good. I modified |
| @@ -53,8 +56,13 @@ class ComposerTest { | |||
| .build(); | |||
| private List<Sample> ListofSamples = Arrays.asList(new Sample[] {sample}); | |||
|
|
|||
| @Before | |||
There was a problem hiding this comment.
Could you change this tag to @BeforeEach?
| @Test | ||
| void gapicClass_addApacheLicense() { | ||
| public void gapicClass_addApacheLicense_validInput_succeeds() { |
There was a problem hiding this comment.
Could you remove the public in the signature?
| @@ -175,7 +179,10 @@ public static GapicContext parse(CodeGeneratorRequest request) { | |||
| mixinServices, | |||
| transport); | |||
|
|
|||
| Preconditions.checkState(!services.isEmpty(), "No services found to generate"); | |||
| if (services.isEmpty()) { | |||
| LOGGER.warning("No services found to generate. This will produce an empty zip file"); | |||
There was a problem hiding this comment.
qq, is this still correct? If
if (response != EMPTY_RESPONSE) {
response.writeTo(System.out);
}
doesn't write anything to System.out does it generate a zip file?
There was a problem hiding this comment.
It's not correct anymore. I corrected the log entry. Thanks for the catch.
| // package info may come as null if we have no services, but we will exit | ||
| // this function early if so. |
There was a problem hiding this comment.
qq, is this also still true? I don't see writePackageInfo() exiting early.
There was a problem hiding this comment.
Not true anymore either. I removed the comment.
| @@ -154,6 +162,16 @@ void composeSamples_parseProtoPackage() { | |||
| } | |||
| } | |||
|
|
|||
| @Test | |||
| public void testEmptyGapicContext_doesNotThrow() { | |||
| Composer.composeServiceClasses(GapicContext.EMPTY); | |||
There was a problem hiding this comment.
nit: Can this be something like assert empty list or assert null instead?
| GapicContext result = Parser.parse(CodeGeneratorRequest.newBuilder().build()); | ||
| assertFalse(result.containsServices()); |
There was a problem hiding this comment.
nit: to match the test method, can this be assert that the result == GapicContext.Empty?
product-auto-label
bot
added
size: l
|
|
🤖 I have created a release *beep* *boop* --- <details><summary>2.42.0</summary> ## [2.42.0](v2.41.0...v2.42.0) (2024-06-25) ### Features * Allow Adding Client Level Attributes to MetricsTracerFactory ([#2614](#2614)) ([f122c6f](f122c6f)) * gapic-generator-java to perform a no-op when no services are detected ([#2460](#2460)) ([c0b5646](c0b5646)) * Make Layout Parser generally available in V1 ([e508ae6](e508ae6)) * populate `.repo-metadata.json` from highest version ([#2890](#2890)) ([f587541](f587541)) * push SNAPSHOT versions of the hermetic build docker image ([#2888](#2888)) ([81df866](81df866)) ### Bug Fixes * **deps:** update the Java code generator (gapic-generator-java) to 1.2.3 ([e508ae6](e508ae6)) * Expose Gax meter name ([#2865](#2865)) ([6c5d6ce](6c5d6ce)) * Move the logic of getting systemProductName from static block to static method ([#2874](#2874)) ([536f1eb](536f1eb)) * Update default Otel Attribute from method_name to method ([#2833](#2833)) ([af10a9e](af10a9e)) ### Dependencies * update dependency com.google.auto.value:auto-value to v1.11.0 ([#2842](#2842)) ([dd27fdf](dd27fdf)) * update dependency com.google.auto.value:auto-value-annotations to v1.11.0 ([#2843](#2843)) ([bf8e67f](bf8e67f)) * update dependency com.google.cloud:grpc-gcp to v1.6.1 ([#2943](#2943)) ([9f16b40](9f16b40)) * update dependency org.checkerframework:checker-qual to v3.44.0 ([#2848](#2848)) ([7a99c50](7a99c50)) * update dependency org.easymock:easymock to v5.3.0 ([#2871](#2871)) ([c243f7d](c243f7d)) * update google api dependencies ([#2846](#2846)) ([b5ef698](b5ef698)) * update googleapis/java-cloud-bom digest to 17cc5ec ([#2882](#2882)) ([d6abd8e](d6abd8e)) * update netty dependencies to v4.1.111.final ([#2877](#2877)) ([b5f10b9](b5f10b9)) * update opentelemetry-java monorepo to v1.39.0 ([#2863](#2863)) ([9d1f3a8](9d1f3a8)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Joe Wang <joewa@google.com>
fixes #2750 Skip parsing a service if no RPCs found for. In the scenario that only one service with no RPCs or all services have no RPCs, falls back to #2460 This pr also reverts a change brought by #985, and removes the relevant tests. For more context, this has been discussed [here](#2750 (comment)). --------- Co-authored-by: Lawrence Qiu <lawrenceqiu@google.com>
Fixes #2050
Adds behavior to gracefully perform a NOOP if no services are contained in the generation request.
Confimation in hermetic build scripts
From
generate_library.shagainstgoogle/cloud/alloydb/connectors/v1I made some changes to library_generation but I moved them to a follow up PR (#2599) so the checks can pass here.