Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update the Javadoc of ObsoleteApi.java #3088

Merged
merged 2 commits into from
Aug 7, 2024
Merged

Conversation

blakeli0
Copy link
Collaborator

@blakeli0 blakeli0 commented Aug 6, 2024

Update the Javadoc of ObsoleteApi.java. It's preferred to provide reasons and alternatives directly in the description, rather than links, as links are not stable.

Update the Javadoc of ObsoleteApi.java. It's better to provide reasons and alternatives directly in the description, rather than links, as links are not stable.
@product-auto-label product-auto-label bot added the size: xs Pull request size is extra small. label Aug 6, 2024
@blakeli0 blakeli0 requested review from zhumin8 and lqiu96 August 6, 2024 21:27
Copy link

sonarcloud bot commented Aug 6, 2024

Copy link

sonarcloud bot commented Aug 6, 2024

Quality Gate Passed Quality Gate passed for 'java_showcase_integration_tests'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@zhumin8 zhumin8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
vaguely related question, when do we use @ObsoleteApi vs. @Deprecated. Is @ObsoleteApi intended for APIs prior to deprecation, meaning it will be replaced with @Deprecated in the future?

@blakeli0
Copy link
Collaborator Author

blakeli0 commented Aug 7, 2024

LGTM vaguely related question, when do we use @ObsoleteApi vs. @Deprecated. Is @ObsoleteApi intended for APIs prior to deprecation, meaning it will be replaced with @Deprecated in the future?

Yes, that's exactly the use case. In general, we don't want to introduce @Deprecated unless it is a major version update.

@blakeli0 blakeli0 merged commit 0ef6619 into main Aug 7, 2024
47 of 48 checks passed
@blakeli0 blakeli0 deleted the blakeli0-patch-4 branch August 7, 2024 15:10
mpeddada1 pushed a commit that referenced this pull request Aug 16, 2024
🤖 I have created a release *beep* *boop*
---


<details><summary>2.44.0</summary>

##
[2.44.0](v2.43.0...v2.44.0)
(2024-08-16)


### Features

* update ErrorDetails to allow unpacking arbitrary messages
([#3073](#3073))
([6913db5](6913db5))


### Bug Fixes

* Generator callable generation is based on method type
([#3075](#3075))
([c21a013](c21a013))
* improve warnings for Direct Path xDS set via env
([#3019](#3019))
([7a26115](7a26115))


### Dependencies

* update dependency argcomplete to v3.5.0
([#3099](#3099))
([0654a28](0654a28))
* update dependency black to v24.8.0
([#3082](#3082))
([a864f62](a864f62))
* update dependency com.google.crypto.tink:tink to v1.14.1
([#3083](#3083))
([c13b63e](c13b63e))
* update dependency com.google.errorprone:error_prone_annotations to
v2.30.0
([#3100](#3100))
([a10ef54](a10ef54))
* update dependency com.google.errorprone:error_prone_annotations to
v2.30.0
([#3101](#3101))
([9bff64f](9bff64f))
* update dependency lxml to v5.3.0
([#3102](#3102))
([4e145b1](4e145b1))
* update dependency org.apache.commons:commons-lang3 to v3.16.0
([#3103](#3103))
([95c9508](95c9508))
* update dependency org.checkerframework:checker-qual to v3.46.0
([#3081](#3081))
([2431920](2431920))
* update dependency org.easymock:easymock to v5.4.0
([#3079](#3079))
([182ae50](182ae50))
* update dependency pyyaml to v6.0.2
([#3086](#3086))
([f847e45](f847e45))
* update dependency watchdog to v4.0.2
([#3094](#3094))
([f1c75a1](f1c75a1))
* update google api dependencies
([#3071](#3071))
([c5abe90](c5abe90))
* update google auth library dependencies to v1.24.1
([#3109](#3109))
([62acdd6](62acdd6))
* update googleapis/java-cloud-bom digest to a98202d
([#3097](#3097))
([bb216ae](bb216ae))
* update googleapis/java-cloud-bom digest to ad905cc
([#3080](#3080))
([250b26c](250b26c))
* update grpc dependencies to v1.66.0
([#3104](#3104))
([b63b643](b63b643))
* update opentelemetry-java monorepo to v1.41.0
([#3105](#3105))
([7364916](7364916))
* update protobuf to 3.25.4
([#3113](#3113))
([2b271fc](2b271fc))
* update slf4j monorepo to v2.0.16
([#3098](#3098))
([c13f932](c13f932))


### Documentation

* Update the Javadoc of ObsoleteApi.java
([#3088](#3088))
([0ef6619](0ef6619))
</details>

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants