Skip to content
This repository has been archived by the owner on May 29, 2023. It is now read-only.

fix: delete only excess data #1092

Merged
merged 3 commits into from
May 23, 2022
Merged

fix: delete only excess data #1092

merged 3 commits into from
May 23, 2022

Conversation

tmatsuo
Copy link
Contributor

@tmatsuo tmatsuo commented May 20, 2022

fixes #1091

@tmatsuo tmatsuo requested a review from a team as a code owner May 20, 2022 20:32
@tmatsuo tmatsuo requested a review from a team May 20, 2022 20:32
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label May 20, 2022
bcoe
bcoe reviewed May 20, 2022
View reviewed changes
Copy link
Contributor

@bcoe bcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty reasonable to me, but I'm tired and want to be careful with this change. Perhaps see if Jeff C., would be willing to take a look next week too?

src/exportToSheets.ts Outdated Show resolved Hide resolved
src/exportToSheets.ts Show resolved Hide resolved
@tmatsuo
Copy link
Contributor Author

tmatsuo commented May 20, 2022

@bcoe Thanks, PTAL

@tmatsuo tmatsuo merged commit 554504c into main May 23, 2022
@tmatsuo tmatsuo deleted the fix-empty branch May 23, 2022 18:17
This was referenced May 23, 2022
Closed
Closed
Closed
@release-please release-please bot mentioned this pull request Jun 8, 2022
Closed
@release-please release-please bot mentioned this pull request Jun 16, 2022
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bcoe bcoe bcoe left review comments

@chingor13 chingor13 chingor13 approved these changes

Assignees

@chingor13 chingor13

@bcoe bcoe

Labels
size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

scheduler job should wipe only unnecessary cells
3 participants
@tmatsuo @chingor13 @bcoe