Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warning is send out a teeny bit too early #341

Open
gnorbsl opened this issue Oct 10, 2024 · 0 comments
Open

Warning is send out a teeny bit too early #341

gnorbsl opened this issue Oct 10, 2024 · 0 comments
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@gnorbsl
Copy link

gnorbsl commented Oct 10, 2024

The library sends warnings out a teeny bit too early

if I create 5000 concurrent requests
then a warning is received that 5000 requests exceed the default of 5000

it should either use > here this._concurrentRequests >= this._options.concurrentRequests or the warning should be changed
@gnorbsl gnorbsl added priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gnorbsl