This repository has been archived by the owner on Feb 2, 2021. It is now read-only.
Fix CSS declaration skip after extra semicolon #2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you add some test cases to cssparser_test.js? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1993
This issue happens because
declaration()is called with a token list such asThe token
;is recognized as an invalid identifier, and the parser advances the token stream until the next semicolon (or closing brace).With this patch, the parser will advance a single token when meeting either whitespace or a semicolon, thus fixing the issue.
Alternative patches that may be considered:
skipDeclaration()?