Skip to content
This repository has been archived by the owner on Mar 13, 2018. It is now read-only.

exiting with a non-zero code when build fails #17

Closed
wants to merge 1 commit into from
Closed

exiting with a non-zero code when build fails #17

wants to merge 1 commit into from

Conversation

dlockhart
Copy link

This fixes #16 by exiting with a non-zero value.

@ankon
Copy link

ankon commented Jun 24, 2016

Independently hit the same issue: https://github.com/Collaborne/web-component-shards/tree/improvement/cli-exit-code-on-error

There is also another place that "eats" errors, and I think that one should be fixed as well: https://github.com/Collaborne/web-component-shards/tree/improvement/no-silent-error, maybe we can join this one into this PR?

@dlockhart
Copy link
Author

@ankon glad we're both running into the same issues! :)

If it's cool with you, I'd rather keep these as 2 separate PRs... I'm a big fan of small, safe changes that fix a very specific problem. It'll probably make each of them more likely to get accepted and merged as well!

@dlockhart
Copy link
Author

Closing due to age.

@dlockhart dlockhart closed this Oct 2, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

errors during build result in a successful exit code
2 participants