Skip to content

Commit 9def0a6

Browse files
committed
move metrics into dedicated metrics/ folder
1 parent 38831b7 commit 9def0a6

14 files changed

+51
-50
lines changed

lighthouse-core/audits/estimated-input-latency.js renamed to lighthouse-core/audits/metrics/estimated-input-latency.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
*/
66
'use strict';
77

8-
const Audit = require('./audit');
8+
const Audit = require('../audit');
99

1010
class EstimatedInputLatency extends Audit {
1111
/**

lighthouse-core/audits/first-contentful-paint.js renamed to lighthouse-core/audits/metrics/first-contentful-paint.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@
55
*/
66
'use strict';
77

8-
const Audit = require('./audit');
9-
const Util = require('../report/html/renderer/util.js');
8+
const Audit = require('../audit');
9+
const Util = require('../../report/html/renderer/util.js');
1010

1111
class FirstContentfulPaint extends Audit {
1212
/**

lighthouse-core/audits/first-cpu-idle.js renamed to lighthouse-core/audits/metrics/first-cpu-idle.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@
55
*/
66
'use strict';
77

8-
const Audit = require('./audit');
9-
const Util = require('../report/html/renderer/util.js');
8+
const Audit = require('../audit');
9+
const Util = require('../../report/html/renderer/util.js');
1010

1111
class FirstCPUIdle extends Audit {
1212
/**

lighthouse-core/audits/first-meaningful-paint.js renamed to lighthouse-core/audits/metrics/first-meaningful-paint.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@
55
*/
66
'use strict';
77

8-
const Audit = require('./audit');
9-
const Util = require('../report/html/renderer/util');
8+
const Audit = require('../audit');
9+
const Util = require('../../report/html/renderer/util');
1010

1111
class FirstMeaningfulPaint extends Audit {
1212
/**

lighthouse-core/audits/interactive.js renamed to lighthouse-core/audits/metrics/interactive.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@
55
*/
66
'use strict';
77

8-
const Audit = require('./audit');
9-
const Util = require('../report/html/renderer/util');
8+
const Audit = require('../audit');
9+
const Util = require('../../report/html/renderer/util');
1010

1111
/**
1212
* @fileoverview This audit identifies the time the page is "consistently interactive".

lighthouse-core/audits/speed-index.js renamed to lighthouse-core/audits/metrics/speed-index.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5,8 +5,8 @@
55
*/
66
'use strict';
77

8-
const Audit = require('./audit');
9-
const Util = require('../report/html/renderer/util');
8+
const Audit = require('../audit');
9+
const Util = require('../../report/html/renderer/util');
1010

1111
class SpeedIndex extends Audit {
1212
/**

lighthouse-core/config/default-config.js

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -73,16 +73,16 @@ module.exports = {
7373
'works-offline',
7474
'viewport',
7575
'without-javascript',
76-
'first-contentful-paint',
77-
'first-meaningful-paint',
76+
'metrics/first-contentful-paint',
77+
'metrics/first-meaningful-paint',
7878
'load-fast-enough-for-pwa',
79-
'speed-index',
79+
'metrics/speed-index',
8080
'screenshot-thumbnails',
81-
'estimated-input-latency',
81+
'metrics/estimated-input-latency',
8282
'errors-in-console',
8383
'time-to-first-byte',
84-
'first-cpu-idle',
85-
'interactive',
84+
'metrics/first-cpu-idle',
85+
'metrics/interactive',
8686
'user-timings',
8787
'critical-request-chains',
8888
'redirects',

lighthouse-core/runner.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -292,6 +292,7 @@ class Runner {
292292
const fileList = [
293293
...fs.readdirSync(path.join(__dirname, './audits')),
294294
...fs.readdirSync(path.join(__dirname, './audits/dobetterweb')).map(f => `dobetterweb/${f}`),
295+
...fs.readdirSync(path.join(__dirname, './audits/metrics')).map(f => `metrics/${f}`),
295296
...fs.readdirSync(path.join(__dirname, './audits/seo')).map(f => `seo/${f}`),
296297
...fs.readdirSync(path.join(__dirname, './audits/seo/manual')).map(f => `seo/manual/${f}`),
297298
...fs.readdirSync(path.join(__dirname, './audits/accessibility'))

lighthouse-core/test/audits/estimated-input-latency-test.js renamed to lighthouse-core/test/audits/metrics/estimated-input-latency-test.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,13 +5,13 @@
55
*/
66
'use strict';
77

8-
const Audit = require('../../audits/estimated-input-latency');
9-
const Runner = require('../../runner');
10-
const Util = require('../../report/html/renderer/util');
8+
const Audit = require('../../../audits/metrics/estimated-input-latency.js');
9+
const Runner = require('../../../runner');
10+
const Util = require('../../../report/html/renderer/util');
1111
const assert = require('assert');
1212
const options = Audit.defaultOptions;
1313

14-
const pwaTrace = require('../fixtures/traces/progressive-app-m60.json');
14+
const pwaTrace = require('../../fixtures/traces/progressive-app-m60.json');
1515

1616
const computedArtifacts = Runner.instantiateComputedArtifacts();
1717

lighthouse-core/test/audits/first-contentful-paint-test.js renamed to lighthouse-core/test/audits/metrics/first-contentful-paint-test.js

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -4,14 +4,13 @@
44
* Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.
55
*/
66
'use strict';
7-
8-
const Audit = require('../../audits/first-contentful-paint.js');
9-
const Runner = require('../../runner.js');
7+
const Audit = require('../../../audits/metrics/first-contentful-paint');
8+
const Runner = require('../../../runner.js');
109
const assert = require('assert');
1110
const options = Audit.defaultOptions;
1211

13-
const pwaTrace = require('../fixtures/traces/progressive-app-m60.json');
14-
const pwaDevtoolsLog = require('../fixtures/traces/progressive-app-m60.devtools.log.json');
12+
const pwaTrace = require('../../fixtures/traces/progressive-app-m60.json');
13+
const pwaDevtoolsLog = require('../../fixtures/traces/progressive-app-m60.devtools.log.json');
1514

1615
/* eslint-env mocha */
1716

0 commit comments

Comments
 (0)