Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc(commitizen): new-audit => new_audit #3534

Merged
merged 1 commit into from
Oct 11, 2017
Merged

misc(commitizen): new-audit => new_audit #3534

merged 1 commit into from
Oct 11, 2017

Conversation

paulirish
Copy link
Member

konrad discovered that 'new-audit' wasn't being handled correctly

root issue: conventional-commits-parser package has headerPattern: /^(\w*)(?:\(([\w\$\.\-\* ]*)\))?\: (.*)$/, and this regex of (\w*) doesn't include dashes.

underscore works and kinda looks better anyway, so we'll move to that, ya?

Copy link
Member

@brendankenny brendankenny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L_G_T_M

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants