Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(headless-chrome.md): fix broken link #4523

Merged
merged 1 commit into from
Feb 13, 2018
Merged

docs(headless-chrome.md): fix broken link #4523

merged 1 commit into from
Feb 13, 2018

Conversation

ebidel
Copy link
Contributor

@ebidel ebidel commented Feb 12, 2018

No description provided.

patrickhulce
patrickhulce reviewed Feb 13, 2018
View reviewed changes
Copy link
Collaborator

@patrickhulce patrickhulce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we fix it to a particular hash/tag so it won't ever be a broken link?

paulirish
paulirish approved these changes Feb 13, 2018
View reviewed changes
Copy link
Member

@paulirish paulirish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm good with this as a permalink

@ebidel ebidel merged commit 9b56ccb into master Feb 13, 2018
@ebidel ebidel deleted the ebidel-patch-3 branch February 13, 2018 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickhulce patrickhulce patrickhulce left review comments

@paulirish paulirish paulirish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ebidel @paulirish @patrickhulce @devtools-bot