core(render-blocking): handle amp-style stylesheets #4555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulirish
reviewed
Feb 21, 2018
| @@ -90,6 +103,9 @@ | |||
| </style> | |||
| </template> | |||
|
|
|||
| <!-- Force FCP to be ~5s out, necessary to make sure our render-blocking audits still work --> | |||
| <!-- even when other forces were responsible for delaying the render. --> | |||
| <script> while (Date.now() - performance.timing.responseStart < 5000) ; </script> | |||
There was a problem hiding this comment.
can we use an add'l stylesheet with delay=5000 instead? Seems more natural.
There was a problem hiding this comment.
unfortunately, no. since the only way we assert that we didn't flag the amp stylesheet is by asserting the overall render-blocking stylesheets value is <3s. in the future details, but extendedInfo-style world this will be easier :)
| prev.push({ | ||
| tag, | ||
| transferSize: request.transferSize || 0, | ||
| startTime: request.startTime, | ||
| endTime: request.endTime, | ||
| endTime: Math.min(request.endTime, request.startTime + earliestNonBlockingTime / 1000), |
There was a problem hiding this comment.
can you extract request.startTime + earliestNonBlockingTime / 1000) into a variable above?
paulirish
approved these changes
Feb 22, 2018
| @@ -30,7 +30,7 @@ function installMediaListener() { | |||
| window.___linkMediaChanges.push({ | |||
| url: this.href, | |||
There was a problem hiding this comment.
naming bikesheds?
url => href
value => media
time => msSinceHTMLEnd
matches == matches
| // Even if the request was initially blocking or appeared to be blocking once the | ||
| // page was loaded, the media attribute could have been changed during load, capping the | ||
| // amount of time it was render blocking. See https://github.com/GoogleChrome/lighthouse/issues/2832. | ||
| const nonMatchingMediaChangeTimes = (tag.mediaChanges || []) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2832