core(tsc): add type defs for Chrome Remote Debugging Protocol #4816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulirish
approved these changes
Mar 20, 2018
typings/gatherer.d.ts
Outdated
| devtoolsLog: Array<void>; | ||
| trace: {trraceEvents: Array<LH.TraceEvent>} | ||
| export interface LoadData { | ||
| networkRecords: Array<Crdp.Network.Response>; |
There was a problem hiding this comment.
this seems like the response from the protocol which is quite different from the JS class we use from WebInspector
There was a problem hiding this comment.
yeah, that was just a check that it's working. First person to use it can expand to the actual type :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
vscode-chrome-debug-corehas up-to-date type defs for the protocol. Pull those in until ChromeDevTools/devtools-protocol#55 is fixedThis exposes the types on
LH.Crdp.*(e.g.LH.Crdp.Network.Response). Happy to bikeshed.Once again github is tricked by indentation. Check out ?w=1 for a better diff