tests: add CI test to confirm sample_v2.json is up to date #4956
Conversation
paulirish
requested review from
patrickhulce and
brendankenny
and removed request for
patrickhulce
| #!/usr/bin/env bash | ||
|
|
||
| ## | ||
| # @license Copyright 2017 Google Inc. All Rights Reserved. |
| @@ -0,0 +1,26 @@ | |||
| #!/usr/bin/env node | |||
There was a problem hiding this comment.
wanna kebab-case this file?
| @@ -0,0 +1,49 @@ | |||
| #!/usr/bin/env bash | |||
There was a problem hiding this comment.
wanna kebab-case this sucker?
| @@ -36,6 +36,7 @@ script: | |||
| - yarn unit:silentcoverage | |||
| - yarn type-check | |||
| - yarn closure | |||
| - yarn diff:sample-json | |||
There was a problem hiding this comment.
let's throw it into yarn test too for local snazziness :)
might need to revert the file to original state though?
There was a problem hiding this comment.
might need to revert the file to original state though?
For CI: no changes, so no worries, right? right.
For local: yes, working copy could have changes already. In this case, it seems like you'd want to get reported on the fact that your working copy, while changed, is still not where it needs to be. But it seems like you wouldn't want a failure when you've already bumped the JSON.
| if [ $retVal -eq 0 ]; then | ||
| colorText "✅ PASS. No change in LHR." "$green" | ||
| else | ||
| colorText "❌ FAIL. LHR has changed." "$red" |
There was a problem hiding this comment.
should this include something like "make sure to run update:sample-json and check in the result?"
| */ | ||
| 'use strict'; | ||
|
|
||
| /** @fileoverview Read in a LHR JSON file, remove whatever shouldn't be compared, write it back. */ |
There was a problem hiding this comment.
rename file (cleanup-LHR-for-diff.js?) maybe? Unclear what the cleanup is for
|
from the failing tests (this test :), I think you need to rebase? |
from #4951 (comment)
is this what ya'll were thinking?
Currently changes within
LHR.timingare ignored. I could also see us ignore changes toauditResult.helpTextto make kayce's PRs easier.