core(image-usage): use min of resourceSize/transferSize #4968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -79,14 +79,15 @@ class OptimizedImages extends Gatherer { | |||
| const isSameOrigin = URL.originsMatch(pageUrl, record._url); | |||
| const isBase64DataUri = /^data:.{2,40}base64\s*,/.test(record._url); | |||
|
|
|||
| if (isOptimizableImage && record._resourceSize > MINIMUM_IMAGE_SIZE) { | |||
| const actualResourceSize = Math.min(record._resourceSize, record._transferSize); | |||
There was a problem hiding this comment.
can _transferSize be larger than _resourceSize? Seems possible, especially with image data, but even in that case wouldn't we still want to use the transfer size because they're sending too many bytes (it's just in that case one of the culprits is a bad choice to gzip?)
There was a problem hiding this comment.
in every case I've seen with my own two 👀 for images transferSize = resourceSize + size of headers, highly irregular to try to gzip/brotli/etc an image since images are always compressed with their own domain-specific method that is way more effective, but apparently the tweet ran into that case with a 30MB image 😆
|
looks like these tests might be helped by #4988? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
should fix https://twitter.com/dougsillars/status/984786614156189697